Conversation
ishajos
changed the title
Doohl
approved these changes
Jun 9, 2025
Contributor
Doohl
left a comment
Doohl
left a comment
There was a problem hiding this comment.
Changes look good overall!
One feedback I can give: avoid authoring PRs without describing how the changes were tested. At minimum, a PR should describe testing strategy (unit, integ, manual) alongside the actual description of change done.
I would also recommend to manually test this against the entire swift agent, if that's possible at this point. The changes here are minimal enough that I won't block on this additional manual test.
oam-mit
approved these changes
Jun 9, 2025
oam-mit
left a comment
oam-mit
left a comment
There was a problem hiding this comment.
Looks good, but can you please provide testing results in the PR description
limhjgrace
reviewed
Jun 10, 2025
williazz
reviewed
Jun 13, 2025
limhjgrace
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
aliasto rum config.This will be used to compare against the alias provided in the resource based policy attached to the appmonitor
Testing
Added unit tests for rum config reader
Tested changes using sample app
Results
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.